ADD: reconnecting to modbus on configure#11
Merged
macmacal merged 11 commits intohumble-develfrom Mar 11, 2025
Merged
Conversation
macmacal
requested changes
Mar 7, 2025
robotiq_hande_driver/hardware/include/robotiq_hande_driver/communication.hpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Maciej Aleksandrowicz <mac.aleksandrowicz@gmail.com>
Co-authored-by: Maciej Aleksandrowicz <mac.aleksandrowicz@gmail.com>
Co-authored-by: Maciej Aleksandrowicz <mac.aleksandrowicz@gmail.com>
Co-authored-by: Maciej Aleksandrowicz <mac.aleksandrowicz@gmail.com>
Co-authored-by: Maciej Aleksandrowicz <mac.aleksandrowicz@gmail.com>
Co-authored-by: Maciej Aleksandrowicz <mac.aleksandrowicz@gmail.com>
Co-authored-by: Maciej Aleksandrowicz <mac.aleksandrowicz@gmail.com>
Co-authored-by: Maciej Aleksandrowicz <mac.aleksandrowicz@gmail.com>
Contributor
Author
|
reworked to for-loop, fixed issue, retested on aegis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds to configuration procedure retries to establish connection to modbus. Initially it was meant to be placed in on_error handler, but so far we always need 2-3 retries so we treat it as regular behaviour and the loop is in the on_configure part.
Motivation and context
Not always serial port is opened before controller hardware layer wants to initiate connection to modbus. This results in error in connection and further processing.
Closes #10
How has this been tested?
Tested manually with robotiq_hande_driver package (on real hardware).
Checklist
Clickup task: 86986zx0u